Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
Meaningless variable name: Variable x is declared with a meaningless single-letter name and assigned true without
clear purpose or usage

bool x              = true;

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
Meaningless variable name: Variable x is declared with a meaningless single-letter name and assigned true without
clear purpose or usage

bool x              = true;

Learn more about managing compliance generic rules or creating your own custom rules

Modify the ShouldResolveCompositionHandlerWithFactory test to validate that the
correct composed handler (CompositionWrapper) is registered for the
subscription, instead of only checking the inner handler (TestHandler).

src/Core/test/Eventuous.Tests.Subscriptions/CompositionHandlerTests.cs [38-45]

 [Test]
 public async Task ShouldResolveCompositionHandlerWithFactory() {
     // This test validates that AddCompositionEventHandler correctly registers
     // handlers when using a factory function
-    var handler = _server.Services.GetRequiredKeyedService<TestHandler>("sub-with-factory");
-    await Assert.That(handler).IsNotNull();
-    await Assert.That(handler.Dependency.Value).IsEqualTo("test-value");
+    var subs = _server.Services.GetServices<TestSub>().ToArray();
+    var sub  = subs.FirstOrDefault(x => x.SubscriptionId == "sub-with-factory");
+    sub.ShouldNotBeNull();
+
+    var handlers = sub.ResolveHandlers(_server.Services);
+    await Assert.That(handlers.Length).IsEqualTo(1);
+    var handler = handlers[0];
+    await Assert.That(handler).IsInstanceOfType(typeof(CompositionWrapper));
 }

• Apply / Chat

The PR contains unrelated refactoring and stylistic changes in Azure and
EventStoreDB components. These should be removed to keep the PR focused solely
on the intended bug fix for DI registration.

Examples:

class ServiceBusMessageBuilder(
        IEventSerializer                serializer,
        string                          streamName,
        ServiceBusMessageAttributeNames attributes,
        ServiceBusProduceOptions?       options                = null,
        Action<string>?                 setActivityMessageType = null
    ) {

                    bool x              = true;

Solution Walkthrough:

Before:

// In src/Azure/.../ServiceBusMessageBuilder.cs
class ServiceBusMessageBuilder(
        IEventSerializer                serializer,
        string                          streamName,
        ...
    ) {
    // ... class refactored to use primary constructor
}

// In src/EventStore/.../EsdbEventStore.cs
public async Task<StreamEvent[]> ReadEvents(...) {
    ...
    var  resolvedEvents = await read.ToArrayAsync(cancellationToken).NoContext();
    bool x              = true; // Unused variable
    return ToStreamEvents(resolvedEvents);
    ...
}

After:

// The following files should not be included in this PR,
// as their changes are unrelated to the main bug fix:
// - src/Azure/src/Eventuous.Azure.ServiceBus/Producers/ServiceBusMessageBuilder.cs
// - src/Azure/src/Eventuous.Azure.ServiceBus/Shared/ServiceBusHelper.cs
// - src/Azure/test/Eventuous.Tests.Azure.ServiceBus/IsSerialisableByServiceBus.cs
// - src/EventStore/src/Eventuous.EventStore/EsdbEventStore.cs

// The PR should only contain changes related to the bug fix in:
// - src/Core/src/Eventuous.Subscriptions/Registrations/SubscriptionBuilder.cs
// - src/Core/test/Eventuous.Tests.Subscriptions/CompositionHandlerTests.cs